From b1238438373a7e3bc0873ceced595639e0532cc1 Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Mon, 9 Sep 2013 17:39:26 -0400 Subject: [PATCH] [#1479] when clicking guild member name, replace their limited loaded data with more full data from server --- public/js/services/memberServices.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/public/js/services/memberServices.js b/public/js/services/memberServices.js index 2cfec887e9..f4cad5923b 100644 --- a/public/js/services/memberServices.js +++ b/public/js/services/memberServices.js @@ -26,7 +26,7 @@ angular.module('memberServices', ['ngResource']). if (_.isString(member)) return; // lazy-load - if (!members[member._id]) members[member._id] = member; + members[member._id] = member; }) } @@ -44,9 +44,7 @@ angular.module('memberServices', ['ngResource']). // individual Member if (obj._id) { - if (!members[obj._id]) { - members[obj._id] = obj; - } + members[obj._id] = obj; } }, @@ -59,7 +57,9 @@ angular.module('memberServices', ['ngResource']). */ selectMember: function(uid) { var self = this; - if (members[uid]) { + // Fetch from cache if we can. For guild members, only their uname will have been fetched on initial load, + // check if they have full fields (eg, check profile.items) and if not, fetch them + if (members[uid] && members[uid].items) { self.selectedMember = members[uid]; } else { Member.get({uid: uid}, function(member){