From bbe4759691b8fea39b3429fc4b52f6b903cdee94 Mon Sep 17 00:00:00 2001 From: Blade Barringer Date: Tue, 13 Sep 2016 12:11:56 -0500 Subject: [PATCH] fix(client): Correct behavior for editting new tasks --- common/script/ops/addTask.js | 4 ++++ test/common/ops/addTask.js | 2 ++ 2 files changed, 6 insertions(+) diff --git a/common/script/ops/addTask.js b/common/script/ops/addTask.js index 2c4ea159e2..83a267071a 100644 --- a/common/script/ops/addTask.js +++ b/common/script/ops/addTask.js @@ -1,4 +1,5 @@ import taskDefaults from '../libs/taskDefaults'; +import clone from 'lodash/lang/clone'; // TODO move to client since it's only used there? @@ -8,6 +9,9 @@ module.exports = function addTask (user, req = {body: {}}) { user[`${task.type}s`].unshift(task); task._editing = user.preferences.newTaskEdit; + if (task._editing) { + task._edit = clone(task); + } task._tags = !user.preferences.tagsCollapsed; task._advanced = !user.preferences.advancedCollapsed; diff --git a/test/common/ops/addTask.js b/test/common/ops/addTask.js index 5968864d7e..d55a77c389 100644 --- a/test/common/ops/addTask.js +++ b/test/common/ops/addTask.js @@ -117,9 +117,11 @@ describe('shared.ops.addTask', () => { it('respects newTaskEdit preference', () => { user.preferences.newTaskEdit = true; expect(addTask(user)._editing).to.be.ok; + expect(addTask(user)._edit).to.be.ok; user.preferences.newTaskEdit = false; expect(addTask(user)._editing).not.be.ok; + expect(addTask(user)._edit).to.not.be.ok; }); it('respects tagsCollapsed preference', () => {