sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-13 07:18:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix asc/desc sort order when sorted by name (#11919)

Browse source 
* Fix asc/desc sort order when sorted by name

* Revert changes.

Use localeCompare but considering sort order
This commit is contained in:
Nik 2020-03-09 17:56:43 +01:00 committed by GitHub
parent 9220323483
commit bdedf8f563
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
website/client/src/components/groups/membersModal.vue
View file

@ -483,7 +483,13 @@ export default {
// If members are to be sorted by name, use localeCompare for case-
// insensitive sort
sortedMembers.sort(
(a, b) => a.profile.name.localeCompare(b.profile.name),
(a, b) => {
if (this.sortOption.direction === 'desc') {
return b.profile.name.localeCompare(a.profile.name);
}
return a.profile.name.localeCompare(b.profile.name);
},
);
} else {
sortedMembers = orderBy(