From c781f46d5394d1cbc1db411a0f9bb57bded25db5 Mon Sep 17 00:00:00 2001 From: Cole Gleason Date: Tue, 28 Jan 2014 16:30:59 -0600 Subject: [PATCH] chore(changelog): add interface and i18n types, update tests This adds extra types that Angular doesn't use. "interface" is for frontend related changes etc. "i18n" means internationalization and refers to translations, etc. Fixes #2622. --- validate-commit-msg.js | 6 ++++-- validate-commit-msg.spec.js | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/validate-commit-msg.js b/validate-commit-msg.js index c1073e8b2b..ee71b175a4 100755 --- a/validate-commit-msg.js +++ b/validate-commit-msg.js @@ -13,7 +13,7 @@ var fs = require('fs'); var util = require('util'); -var MAX_LENGTH = 999; +var MAX_LENGTH = 100; var PATTERN = /^(?:fixup!\s*)?(\w*)(\(([\w\$\.\-\*/]*)\))?\: (.*)$/; var IGNORED = /^WIP\:/; var TYPES = { @@ -25,7 +25,9 @@ var TYPES = { perf: true, test: true, chore: true, - revert: true + revert: true, + 'interface': true, + i18n: true }; diff --git a/validate-commit-msg.spec.js b/validate-commit-msg.spec.js index cc4b4c3c5b..bb789fb90d 100644 --- a/validate-commit-msg.spec.js +++ b/validate-commit-msg.spec.js @@ -34,6 +34,8 @@ describe('validate-commit-msg.js', function() { expect(m.validateMessage('chore(*): something')).toBe(VALID); expect(m.validateMessage('chore(guide/location): something')).toBe(VALID); expect(m.validateMessage('revert(foo): something')).toBe(VALID); + expect(m.validateMessage('i18n(translate): something')).toBe(VALID); + expect(m.validateMessage('interface(ui-change): something')).toBe(VALID); expect(errors).toEqual([]); });