sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-15 00:12:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove unnecessary default for dailyTask.startDate (website/src/models/task.js gives default); give user's timezone to their task startDate values (possible solution for https://github.com/HabitRPG/habitrpg/issues/5395 https://github.com/HabitRPG/habitrpg/issues/5510 https://github.com/HabitRPG/habitrpg/issues/5549)

Browse source
This commit is contained in:
Alys 2015-07-05 17:39:11 +10:00
parent 2fb25207bb
commit d7084ce0c8
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
common/script/index.coffee
View file

@ -83,8 +83,7 @@ api.shouldDo = (day, dailyTask, options = {}) ->
o = sanitizeOptions options
startOfDayWithCDSTime = api.startOfDay(_.defaults {now:day}, o) # a moment()
# If the Daily does not have a Start Date (old tasks predating the Start Date feature), we assume it starts on the day being checked. This does not cause a bug with the Every X Days option because if the user had edited the task to select X days, then a start date would have been saved to the task at the same time.
taskStartDate = dailyTask.startDate || day
taskStartDate = moment(dailyTask.startDate).zone(o.timezoneOffset)
# The time portion of the Start Date is never visible to or modifiable by the user so we must ignore it.
# Therefore, we must also ignore the time portion of the user's day start (startOfDayWithCDSTime), otherwise the date comparison will be wrong for some times.