sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-13 15:38:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

buyMysterySet records every item in Amplitude. (#12197)

Browse source 
* buyMysterySet records every item in Amplitude.

Record only the mysterySet

Fixes: #11705

* buyMysterySet records every item in Amplitude.

Extend unit test

Fixes: #11705
This commit is contained in:
Frank Maximus 2020-05-19 16:39:48 +02:00 committed by GitHub
parent 739963762e
commit ea44af0929
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
test/common/ops/buy/buyMysterySet.js
View file

@ -88,7 +88,14 @@ describe('shared.ops.buyMysterySet', () => {
expect(user.items.gear.owned).to.have.property('armor_mystery_301404', true); expect(user.items.gear.owned).to.have.property('armor_mystery_301404', true);
expect(user.items.gear.owned).to.have.property('head_mystery_301404', true); expect(user.items.gear.owned).to.have.property('head_mystery_301404', true);
expect(user.items.gear.owned).to.have.property('eyewear_mystery_301404', true); expect(user.items.gear.owned).to.have.property('eyewear_mystery_301404', true);
expect(analytics.track).to.be.called; expect(analytics.track).to.be.calledOnce;
expect(analytics.track).to.be.calledWithMatch('acquire item', {
uuid: user._id,
itemKey: '301404',
itemType: 'Subscriber Gear',
acquireMethod: 'Hourglass',
category: 'behavior',
});
}); });
}); });
}); });

21
website/common/script/ops/buy/buyMysterySet.js
View file

@ -26,18 +26,19 @@ export default function buyMysterySet (user, req = {}, analytics) {
each(mysterySet.items, item => { each(mysterySet.items, item => {
user.items.gear.owned[item.key] = true; user.items.gear.owned[item.key] = true;
if (analytics) {
analytics.track('acquire item', {
uuid: user._id,
itemKey: item.key,
itemType: 'Subscriber Gear',
acquireMethod: 'Hourglass',
category: 'behavior',
headers: req.headers,
});
}
}); });
if (analytics) {
analytics.track('acquire item', {
uuid: user._id,
itemKey: mysterySet.key,
itemType: 'Subscriber Gear',
acquireMethod: 'Hourglass',
category: 'behavior',
headers: req.headers,
});
}
// Here we need to trigger vue reactivity through reassign object // Here we need to trigger vue reactivity through reassign object
user.items.gear.owned = { user.items.gear.owned = {
...user.items.gear.owned, ...user.items.gear.owned,