From ea5ce64db6baec462976a126c8d48caeb51811e0 Mon Sep 17 00:00:00 2001 From: Sabe Jones Date: Fri, 22 Feb 2019 15:47:24 -0600 Subject: [PATCH] fix(email): use updated slugs and genericize logic for easier tweaking later --- website/server/libs/auth/index.js | 4 ++-- website/server/models/user/hooks.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/website/server/libs/auth/index.js b/website/server/libs/auth/index.js index db6d76e586..1a806ead3c 100644 --- a/website/server/libs/auth/index.js +++ b/website/server/libs/auth/index.js @@ -184,8 +184,8 @@ async function registerLocal (req, res, { isV3 = false }) { .remove({email: savedUser.auth.local.email}) .then(() => { if (existingUser) return; - if (savedUser._ABtests && savedUser._ABtests.emailSplit && savedUser._ABtests.emailSplit === '20190222_welcome-v2') { - sendTxnEmail(savedUser, 'welcome-v2'); + if (savedUser._ABtests && savedUser._ABtests.welcomeEmailSplit) { + sendTxnEmail(savedUser, savedUser._ABtests.welcomeEmailSplit); } else { sendTxnEmail(savedUser, 'welcome'); } diff --git a/website/server/models/user/hooks.js b/website/server/models/user/hooks.js index 4138eb3da1..af5e4146e5 100644 --- a/website/server/models/user/hooks.js +++ b/website/server/models/user/hooks.js @@ -130,9 +130,9 @@ function _setUpNewUser (user) { const testGroup = Math.random(); if (testGroup < 0.5) { - user._ABtests.emailSplit = '20190222_welcome'; + user._ABtests.welcomeEmailSplit = 'welcome-v2'; } else { - user._ABtests.emailSplit = '20190222_welcome-v2'; + user._ABtests.welcomeEmailSplit = 'welcome-v2b'; } if (user.registeredThrough === 'habitica-web') {