mirror of
https://github.com/sudoxnym/brands.git
synced 2026-05-19 03:58:50 +00:00
Remove sRGB requirement for now, until we have better checks
This commit is contained in:
parent
ed9455919d
commit
8340cdbab2
3 changed files with 1 additions and 8 deletions
1
.github/PULL_REQUEST_TEMPLATE.md
vendored
1
.github/PULL_REQUEST_TEMPLATE.md
vendored
|
|
@ -42,7 +42,6 @@
|
|||
-->
|
||||
|
||||
- [ ] The added/replaced image(s) are **PNG**
|
||||
- [ ] The added/replaced image(s) are in the **rRGB** color space
|
||||
- [ ] Icon image size is 256x256px (`icon.png`)
|
||||
- [ ] hDPI icon image size is 512x512px for (`icon@2x.png`)
|
||||
- [ ] Logo image size has min 128px, but max 256px, on the shortest side (`logo.png`)
|
||||
|
|
|
|||
7
.github/workflows/validate/validate.sh
vendored
7
.github/workflows/validate/validate.sh
vendored
|
|
@ -20,7 +20,7 @@ function error() {
|
|||
# Find all files in the src folder (should contain only images)
|
||||
while read image; do
|
||||
# Read properties from image
|
||||
properties=($(identify -format "%w %h %m %[colorspace]" "${image}"))
|
||||
properties=($(identify -format "%w %h %m" "${image}"))
|
||||
if [[ "$?" -ne 0 ]]; then
|
||||
error "${image}" "Could not read image file"
|
||||
continue
|
||||
|
|
@ -31,16 +31,11 @@ while read image; do
|
|||
width="${properties[0]}"
|
||||
height="${properties[1]}"
|
||||
type="${properties[2]}"
|
||||
colorspace="${properties[3]}"
|
||||
|
||||
# Ensure file is actually a PNG file
|
||||
[[ "${type}" != "PNG" ]] \
|
||||
&& error "${image}" "Invalid file type '${type}' for file"
|
||||
|
||||
# Ensure color space is sRGB
|
||||
[[ "${colorspace}" != "sRGB" ]] \
|
||||
&& error "${image}" "Invalid color space '${colorspace}' for file"
|
||||
|
||||
# Validate image dimensions
|
||||
if [[ "${filename}" == "icon.png" ]]; then
|
||||
# icon dimension
|
||||
|
|
|
|||
|
|
@ -49,7 +49,6 @@ our cache.
|
|||
All images must have the following requirements:
|
||||
|
||||
- The filetype of all images must be PNG.
|
||||
- The color space of all images must be rRGB.
|
||||
- They should be properly compressed and optimized (lossless is preferred) for use on the web.
|
||||
- Interlaced is preferred (also known as progressive).
|
||||
- Images with transparency is preferred.
|
||||
|
|
|
|||
Loading…
Reference in a new issue