sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-14 07:52:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixes #12730 - Tag filter not always cleared correctly when deleting active tag (#12737)

Browse source 
* Update title for tabs not including challenges, guild and team

* add section titles to challenges, guilds, and groups

* Update dynamic title to use vuex action

* Remove duplicate key

* Actually remove duplicate key

* Fix section sub section in group

* Add note to implement setTitle when adding a page

* Add missing sections to dynamic title

* Features string not translated

* Use onGroupUpdate to update group titles

* Add watcher to challenges for dynamic title updates

* Small fixes

* Add register and login to title, remove duplicate keys

* Add home page dynamic title functionality

* Minor name changes

* Fix tag filtering on deletion

* Remove debuggers

Co-authored-by: Matteo Pagliazzi <matteopagliazzi@gmail.com>
This commit is contained in:
jbusa22 2020-11-09 06:25:22 -05:00 committed by GitHub
parent 174ac6d7e3
commit 983aae7f87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
website/client/src/components/tasks/user.vue
View file

@ -520,7 +520,13 @@ export default {
removeTag (index, key) {
const tagId = this.tagsSnap[key][index].id;
const indexInSelected = this.selectedTags.indexOf(tagId);
if (indexInSelected !== -1) this.$delete(this.selectedTags, indexInSelected);
const indexInTempSelected = this.temporarilySelectedTags.indexOf(tagId);
if (indexInSelected !== -1) {
this.$delete(this.selectedTags, indexInSelected);
}
if (indexInTempSelected !== -1) {
this.$delete(this.temporarilySelectedTags, indexInTempSelected);
}
this.$delete(this.tagsSnap[key], index);
},
saveTags () {

2
website/client/src/router/index.js
View file

@ -6,6 +6,8 @@ import handleRedirect from './handleRedirect';
import ParentPage from '@/components/parentPage';
// NOTE: when adding a page make sure to implement setTitle
// Static Pages
const StaticWrapper = () => import(/* webpackChunkName: "entry" */'@/components/static/staticWrapper');
const HomePage = () => import(/* webpackChunkName: "entry" */'@/components/static/home');